Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert attributes feature #18355

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Mar 3, 2025

Revert EnforceAttributeTargets to preview.

There were some libraries that relied on a relaxed enforcement of attribute targets, particularly on Union types. This caused F# 9.0 the apps that relied on these libraries.

In order to reduce the number of times we have to fix bugs related to this, we will reset the feature back to preview mode. Allowing us to re-evaluate how we want this to work in the future, we can re-enable the feature when we have a better unsderstood design.

Update, fsharp.core and fsharp.compiler service package version numbers.

/cc @baronfel /cc @T-Gro

@KevinRansom KevinRansom requested a review from a team as a code owner March 3, 2025 22:43
Copy link
Contributor

github-actions bot commented Mar 3, 2025

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.202.md

Copy link
Contributor

@edgarfgp edgarfgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sad to see this been reverted, as this bring back some legit issues where attribute targets incorrectly used specially in values and functions.

Knowing the history of previous preview features not been completed for many years. I would suggest completely removing this feature and rely in the old incorrect behaviour that everyone is relying on.

@KevinRansom
Copy link
Member Author

@edgarfgp --- there is some interesting and good refactoring that happened in the PRs associated with this feature. We should be able to salvage some parts of it. There really is only one preview feature that has remained dormant, the slicing PR, because it was a good feature that we never quite got around to finishing.

Also for servicing, a minimum change PR is pretty much a requirement.

Thanks

Kevin

@KevinRansom KevinRansom merged commit 82a3f54 into dotnet:release/dev17.13 Mar 4, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants