Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More improve completion after method/property override #18341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

More improve completion after method/property override #18341

wants to merge 4 commits into from

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented Feb 26, 2025 •
edited
Loading

Description

  1. Make indent in generated code depend on the context, not fix to 4.
  2. Add a switch to determine whether to generate an default implementation body for overridden method when completing. (See Improve completion after method/property override #17292 (comment))

图片

When checked:

GIF 2025-2-26 21-42-33

When unchecked:

GIF 2025-2-26 21-44-31

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@ijklam ijklam requested a review from a team as a code owner February 26, 2025 13:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

✅ No release notes required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Status: New
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ijklam @psfinaki