Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for breaking change when using Option.ofObj :: Type parameter constraint null implies not struct #18323

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Bugfix for breaking change when using Option.ofObj :: Type parameter constraint null implies not struct #18323

merged 3 commits into from
Feb 21, 2025

Conversation

T-Gro
Copy link
Member

@T-Gro T-Gro commented Feb 17, 2025

Fixes #18320

@T-Gro T-Gro linked an issue Feb 17, 2025 that may be closed by this pull request
Unnecessary(?) breaking change in FSharp.Core 9.0.100: ofObj now requires not struct as well as null #18320
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 17, 2025 •
edited
Loading

❗ Release notes required

✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.300.md

@T-Gro T-Gro marked this pull request as ready for review February 17, 2025 18:28
@T-Gro T-Gro requested a review from a team as a code owner February 17, 2025 18:28
@T-Gro T-Gro enabled auto-merge (squash) February 21, 2025 09:53
@T-Gro T-Gro merged commit 27db996 into main Feb 21, 2025
33 checks passed
@T-Gro T-Gro deleted the 18320-imply-notstruct-from-null branch February 24, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0101 0101 0101 approved these changes

@psfinaki psfinaki psfinaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary(?) breaking change in FSharp.Core 9.0.100: ofObj now requires not struct as well as null
3 participants
@T-Gro @0101 @psfinaki