Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Adam Boniecki <[email protected]>
  • Loading branch information
T-Gro and abonie authored Feb 21, 2025
1 parent feacfca commit b1ab1c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ open FSharp.Core.UnitTests.LibraryTestFx
open Xunit

#nowarn "3397" // This expression uses 'unit' for an 'obj'-typed argument. This will lead to passing 'null' at runtime.
// Why warned - the tests here are actually trying to test that when this happens (unit passed), in indeed results in a null
// Why warned - the tests here are actually trying to test that when this happens (unit passed), it indeed results in a null

type OperatorsModule1() =

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ open Xunit

#nowarn "3370"
#nowarn "3397" // This expression uses 'unit' for an 'obj'-typed argument. This will lead to passing 'null' at runtime.
// Why warned - the tests here are actually trying to test that when this happens (unit passed), in indeed results in a null
// Why warned - the tests here are actually trying to test that when this happens (unit passed), it indeed results in a null

/// If this type compiles without error it is correct
/// Wrong if you see: FS0670 This code is not sufficiently generic. The type variable ^T could not be generalized because it would escape its scope.
Expand Down

0 comments on commit b1ab1c2

Please sign in to comment.