-
Notifications
You must be signed in to change notification settings - Fork 810
add CommTagAttribute for metric code generator #6244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
add CommTagAttribute for metric code generator #6244
Conversation
@dotnet-policy-service agree company="Microsoft" |
This seems like a cool idea. Did you write up an API proposal for this? Since it's a new feature we might want to discuss it there, so that we don't end up having to change things later. |
/// </example> | ||
[AttributeUsage(AttributeTargets.Class, AllowMultiple = true)] | ||
[Conditional("CODE_GENERATION_ATTRIBUTES")] | ||
[Experimental("EXPERIMENTAL_COMMON_TAG_ATTRIBUTE")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should use the well-defined experiment IDs
[Experimental("EXPERIMENTAL_COMMON_TAG_ATTRIBUTE")] | |
[Experimental(diagnosticId: DiagnosticIds.Experiments.Telemetry, UrlFormat = DiagnosticIds.UrlFormat)] |
Thanks Darius. I have created a new feature proposal here: |
Support common tag and value for the same group of metrics
Microsoft Reviewers: Open in CodeFlow