Skip to content

Add Windows disk I/O metrics to ResourceMonitoring #6181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 28, 2025

Conversation

makazeu
Copy link
Contributor

@makazeu makazeu commented Mar 23, 2025

Closes #5842

Add the below new Windows metrics to the ResourceMonitoring library:

  • system.disk.io
  • system.disk.operations

Will try to support below metrics in the future:

  • system.disk.io_time
  • system.disk.operation_time
  • system.disk.pending_operations

Also, will support Linux in the future

Tested in Grafana + Prometheus with OpenTelemetry.Exporter.Prometheus.HttpListener

image

Tested in Geneva with OpenTelemetry.Exporter.Geneva

Screenshot 2025-04-26 042010

Microsoft Reviewers: Open in CodeFlow

@makazeu
Copy link
Contributor Author

makazeu commented Mar 23, 2025

cc @evgenyfedorov2

@makazeu makazeu changed the title Add Windows disk metrics to ResourceMonitoring Add Windows disk I/O metrics to ResourceMonitoring Mar 23, 2025
Copy link
Contributor

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Primarily code style related comments.

@evgenyfedorov2
Copy link
Member

Hi @makazeu , thanks for pickup up this task!

I am busy with other things right now, could you please don't merge this until I have a chance to review it? Will try to review this or next week.

Thanks!

@makazeu
Copy link
Contributor Author

makazeu commented Mar 25, 2025

Hi @makazeu , thanks for pickup up this task!

I am busy with other things right now, could you please don't merge this until I have a chance to review it? Will try to review this or next week.

Thanks!

Sure, Evgeny. This is still a draft yet, I will not merge it until it has more unit tests and you have reviewed it.

@makazeu makazeu marked this pull request as ready for review March 25, 2025 15:56
@makazeu makazeu requested a review from a team as a code owner March 25, 2025 15:56
@makazeu makazeu requested review from a team as code owners March 25, 2025 15:56
@makazeu
Copy link
Contributor Author

makazeu commented Mar 25, 2025

This PR is now ready for review!

Edit: Add screenshosts for my tests with Grafana + Prometeus, and Geneva.

@makazeu
Copy link
Contributor Author

makazeu commented Apr 11, 2025

Hi @evgenyfedorov2 If you get a chance, could you please help review this PR? I'd really appreciate it!

@evgenyfedorov2
Copy link
Member

evgenyfedorov2 commented Apr 14, 2025

Why are screenshots from tests different in absolute values? It is max 50M in Geneva, but only about 3.5M in Grafana.

@makazeu
Copy link
Contributor Author

makazeu commented Apr 15, 2025

Why are screenshots from tests different in absolute values? It is max 50M in Geneva, but only about 3.5M in Grafana.

Because those screenshots were taken at different times. I remember the Geneva screenshot was added a day later.

@makazeu makazeu closed this Apr 15, 2025
@makazeu makazeu reopened this Apr 15, 2025
@evgenyfedorov2
Copy link
Member

I think the code itself looks good, can we just have screenshots taken at the same time, please?

@makazeu
Copy link
Contributor Author

makazeu commented Apr 26, 2025

I think the code itself looks good, can we just have screenshots taken at the same time, please?

Hi @evgenyfedorov2, I updated the screenshots in the PR description, now they were taken at same time. In the two charts, their trends are the same, but due to differences in the aggregation precision, they vary slightly in details. I can't make them completely identical, but overall, they are quite similar.

@evgenyfedorov2 evgenyfedorov2 merged commit c12d3b6 into dotnet:main Apr 28, 2025
6 checks passed
@makazeu makazeu deleted the windows-disk-metrics branch May 4, 2025 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add disk IO metrics to Resource Monitoring
3 participants