Adding more tests for JSON queries with weird/malformed JSON:

[maumar]

• duplicate properties (navigtions and scalars)
• JSON property names being empty strings
• JSON property names being null (invalid)

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

[Copilot]

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

[Copilot]

The JSON structure has duplicated property names (e.g., "NestedOptional", "NestedCollection"), which is invalid JSON. Each property name should be unique within the same object.

Suggested change

	N'{"NestedOptional": { "Text":"or no" }, "NestedOptional": { "Text":"or no dupnav" }, "NestedRequired": { "Text":"or nr" }, "NestedCollection": [ { "Text":"or nc 1" }, { "Text":"or nc 2" } ], "NestedCollection": [ { "Text":"or nc 1 dupnav" }, { "Text":"or nc 2 dupnav" } ], "NestedRequired": { "Text":"or nr dupnav" } }',
	N'{"NestedOptional": { "Text":"rr no" }, "NestedOptional": { "Text":"rr no dupnav" }, "NestedRequired": { "Text":"rr nr" }, "NestedCollection": [ { "Text":"rr nc 1" }, { "Text":"rr nc 2" } ], "NestedCollection": [ { "Text":"rr nc 1 dupnav" }, { "Text":"rr nc 2 dupnav" } ], "NestedRequired": { "Text":"rr nr dupnav" } }',
	N'[
	{"NestedOptional": { "Text":"c 1 no" }, "NestedOptional": { "Text":"c 1 no dupnav" }, "NestedRequired": { "Text":"c 1 nr" }, "NestedCollection": [ { "Text":"c 1 nc 1" }, { "Text":"c 1 nc 2" } ], "NestedCollection": [ { "Text":"c 1 nc 1 dupnav" }, { "Text":"c 1 nc 2 dupnav" } ], "NestedRequired": { "Text":"c 1 nr dupnav" } },
	{"NestedOptional": { "Text":"c 2 no" }, "NestedOptional": { "Text":"c 2 no dupnav" }, "NestedRequired": { "Text":"c 2 nr" }, "NestedCollection": [ { "Text":"c 2 nc 1" }, { "Text":"c 2 nc 2" } ], "NestedCollection": [ { "Text":"c 2 nc 1 dupnav" }, { "Text":"c 2 nc 2 dupnav" } ], "NestedRequired": { "Text":"c 2 nr dupnav" } }
	N'{"NestedOptional": { "Text":"or no" }, "NestedOptionalDup": { "Text":"or no dupnav" }, "NestedRequired": { "Text":"or nr" }, "NestedCollection": [ { "Text":"or nc 1" }, { "Text":"or nc 2" } ], "NestedCollectionDup": [ { "Text":"or nc 1 dupnav" }, { "Text":"or nc 2 dupnav" } ], "NestedRequiredDup": { "Text":"or nr dupnav" } }',
	N'{"NestedOptional": { "Text":"rr no" }, "NestedOptionalDup": { "Text":"rr no dupnav" }, "NestedRequired": { "Text":"rr nr" }, "NestedCollection": [ { "Text":"rr nc 1" }, { "Text":"rr nc 2" } ], "NestedCollectionDup": [ { "Text":"rr nc 1 dupnav" }, { "Text":"rr nc 2 dupnav" } ], "NestedRequiredDup": { "Text":"rr nr dupnav" } }',
	N'[
	{"NestedOptional": { "Text":"c 1 no" }, "NestedOptionalDup": { "Text":"c 1 no dupnav" }, "NestedRequired": { "Text":"c 1 nr" }, "NestedCollection": [ { "Text":"c 1 nc 1" }, { "Text":"c 1 nc 2" } ], "NestedCollectionDup": [ { "Text":"c 1 nc 1 dupnav" }, { "Text":"c 1 nc 2 dupnav" } ], "NestedRequiredDup": { "Text":"c 1 nr dupnav" } },
	{"NestedOptional": { "Text":"c 2 no" }, "NestedOptionalDup": { "Text":"c 2 no dupnav" }, "NestedRequired": { "Text":"c 2 nr" }, "NestedCollection": [ { "Text":"c 2 nc 1" }, { "Text":"c 2 nc 2" } ], "NestedCollectionDup": [ { "Text":"c 2 nc 1 dupnav" }, { "Text":"c 2 nc 2 dupnav" } ], "NestedRequiredDup": { "Text":"c 2 nr dupnav" } }

[maumar]

good observation but this is the point of the test

[Copilot]

The JSON structure has properties with null names, which is invalid JSON. Property names must be valid strings.

Suggested change

	N'{null: { "Text":"or no" }, null: { "Text":"or nr" }, null: [ { "Text":"or nc 1" }, { "Text":"or nc 2" } ] }',
	N'{null: { "Text":"rr no" }, null: { "Text":"rr nr" }, null: [ { "Text":"rr nc 1" }, { "Text":"rr nc 2" } ] }',
	N'[
	{null: { "Text":"c 1 no" }, null: { "Text":"c 1 nr" }, null: [ { "Text":"c 1 nc 1" }, { "Text":"c 1 nc 2" } ] },
	{null: { "Text":"c 2 no" }, null: { "Text":"c 2 nr" }, null: [ { "Text":"c 2 nc 1" }, { "Text":"c 2 nc 2" } ] }
	N'{"OptionalReference": { "Text":"or no" }, "RequiredReference": { "Text":"or nr" }, "Collection": [ { "Text":"or nc 1" }, { "Text":"or nc 2" } ] }',
	N'{"OptionalReference": { "Text":"rr no" }, "RequiredReference": { "Text":"rr nr" }, "Collection": [ { "Text":"rr nc 1" }, { "Text":"rr nc 2" } ] }',
	N'[
	{"OptionalReference": { "Text":"c 1 no" }, "RequiredReference": { "Text":"c 1 nr" }, "Collection": [ { "Text":"c 1 nc 1" }, { "Text":"c 1 nc 2" } ] },
	{"OptionalReference": { "Text":"c 2 no" }, "RequiredReference": { "Text":"c 2 nr" }, "Collection": [ { "Text":"c 2 nc 1" }, { "Text":"c 2 nc 2" } ] }

[maumar]

good observation but this is the point of the test