Skip flaky SqliteCommandTest tests #35578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
cincuranet
reviewed
Feb 4, 2025
| }); | ||
|
|
||
| private static void AssertBusy(int rc) | ||
| => Assert.True(rc is SQLITE_LOCKED or SQLITE_BUSY or SQLITE_LOCKED_SHAREDCACHE or SQLITE_ERROR); |
There was a problem hiding this comment.
The new assert with i.e. SQLITE_ERROR changes the meaning. Shouldn't the test fail if we get SQLITE_ERROR instead of SQLITE_BUSY? It means something else failed, not the expected busy-ness, isn't it?
There was a problem hiding this comment.
That's the error it throws occasionally on CI. Would you prefer to disable these tests and investigate the root cause later?
AndriySvyryd
force-pushed
the
SqliteTests
branch
from
96f3fa8 to
173cae4
Compare
AndriySvyryd
changed the title
cincuranet
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.