Use AssemblyLoadContext to load EFC.Design #35527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@baronfel @ViktorHofer @rainersigwald Please take a look at the first commit to verify whether this is a sane approach to find and load a referenced PrivateAssets assembly when the |
AndriySvyryd
force-pushed
the
Issue35265
branch
from
ef3416c to
49d1065
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no comments.
Files not reviewed (10)
- src/EFCore.Tasks/buildTransitive/Microsoft.EntityFrameworkCore.Tasks.targets: Language not supported
- src/EFCore.Tools/tools/EntityFrameworkCore.psm1: Language not supported
- src/ef/Properties/Resources.Designer.cs: Language not supported
- src/ef/Properties/Resources.resx: Language not supported
- src/EFCore.Tasks/Tasks/Internal/OperationTaskBase.cs: Evaluated as low risk
- src/dotnet-ef/Project.cs: Evaluated as low risk
- src/dotnet-ef/RootCommand.cs: Evaluated as low risk
- src/ef/AppDomainOperationExecutor.cs: Evaluated as low risk
- src/ef/Commands/DbContextOptimizeCommand.cs: Evaluated as low risk
- src/ef/Commands/MigrationsHasPendingModelChangesCommand.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/ef/Commands/MigrationsBundleCommand.cs:39
- The variable 'context' should be nullable or have a null check to ensure consistency with the nullable 'version' variable.
string context;
d55bc66 to
d26173f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35265
Part of #18840