-
Notifications
You must be signed in to change notification settings - Fork 117
Remove NuGet.config links #8235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktork
approved these changes
May 14, 2025
/backport to release/8.x |
Started backporting to release/8.x: https://github.com/dotnet/dotnet-monitor/actions/runs/15033386720 |
wiktork
pushed a commit
that referenced
this pull request
May 15, 2025
Co-authored-by: Justin Anderson <[email protected]>
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/dotnet-monitor/actions/runs/15053514312 |
wiktork
pushed a commit
that referenced
this pull request
May 15, 2025
Co-authored-by: Justin Anderson <[email protected]>
wiktork
pushed a commit
that referenced
this pull request
May 19, 2025
* Update dependencies from https://github.com/dotnet/diagnostics build 20250511.1 (#8228) [main] Update dependencies from dotnet/diagnostics * Update releases information. (#8227) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/diagnostics build 20250512.2 (#8236) [main] Update dependencies from dotnet/diagnostics * Map Uri config value as string (#8234) * Add 8.1.1 release notes (#8237) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Justin Anderson <[email protected]> * Add 9.0.3 release notes (#8238) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Justin Anderson <[email protected]> * generate release notes (#8240) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Register new release information (#8241) * Register v9.1.0-preview.3.25257.5 release information * Register v9.0.3 release information --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Register v8.1.1 release information (#8242) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update dependencies from https://github.com/dotnet/command-line-api build 20250513.1 (#8244) [main] Update dependencies from dotnet/command-line-api * Remove nuget.config links (#8235) * Update dependencies from https://github.com/dotnet/diagnostics build 20250513.2 (#8257) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/command-line-api build 20250515.1 (#8265) [main] Update dependencies from dotnet/command-line-api * Update dependencies from https://github.com/dotnet/diagnostics build 20250515.1 (#8264) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/diagnostics build 20250516.1 (#8271) [main] Update dependencies from dotnet/diagnostics * Update dependencies from https://github.com/dotnet/diagnostics build 20250517.1 (#8272) [main] Update dependencies from dotnet/diagnostics --------- Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sven Boemer <[email protected]> Co-authored-by: Justin Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There have been recent changes to dependabot that are causing the NuGet.config links under each of the dependabot folders to seemingly be ignored. Dependabot them falls back to using nuget.org, which is never what we want to happen. This is causing PRs such as #8216 and #8230 to be opened.
I tested the removal of these file links in my fork of the repo and it seems to behave correctly by locating the NuGet.config at the root of the repository (which the file links were pointing at) and performing updates.
Release Notes Entry