Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set publicSourceBranch var for matrix generation #5968

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from

Conversation

mthalman
Copy link
Member

The changes from #5942 caused a regression in GenerateBuildMatrix job for this repo. It failed in the Set Image Info Path Vars step with this error:

   5 |  $publicSourceBranch = "$(publicSourceBranch)"
     |                           ~~~~~~~~~~~~~~~~~~
     | The term 'publicSourceBranch' is not recognized as a name of a cmdlet,
     | function, script file, or executable program. Check the spelling of the
     | name, or if a path was included, verify that the path is correct and try
     | again.

Example build (internal link)

This occurs because this repo has special logic for setting the publicSourceBranch variable that wasn't being executed for the GenerateBuildMatrix job. It is set in a step template that needs to be passed in as custom init steps to the job, just as it is done for build and other jobs.

These changes include changes to eng/common that I'll backport to docker-tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant