-
Notifications
You must be signed in to change notification settings - Fork 115
Add llvm-symbolizer to all more helix images #966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add llvm-symbolizer to all more helix images #966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to/can we copy the live-built llvm-symbolizer from our cross-build image here so we can ensure our toolchain is consistent?
If that's not possible, I understand. LGTM in that case
@mthalman are these build issues known? They seem to be in npm and Python, but rebuilds didn't help |
it's #903. https://github.com/dotnet/dotnet-buildtools-prereqs-docker/pull/929/files solved this for debian, but there's no binary distribution of python3-cryptography for Alpine. I think we would need to follow the troubleshooting steps in cryptography's documentation under "Rust". |
Actually I lied and found the package. We should try installing |
@lbussell adding that package requires gcc, but that might make the container pretty big. Not sure if purging gcc after is an option, or if we should just let it be |
Hi @lbussell, we need your help to fix this issue. We are trying to roll out the feature by Feb, so we need this done ASAP. |
@JulieLeeMSFT These Dockerfiles are the responsibility of repo owners to maintain (e.g. runtime devs) since they are the devs who need them. I did my best effort to try and fix the problem in my spare time. I see two blocking issues in this PR:
If it's an option, we could disable the images that fail to build. But since @hoyosjs touched the files that are failing to build I'm guessing they're important. |
Probably @dougbu has some insights on this? |
I generally agree w/ @lbussell. we haven't found viable workarounds for the |
Submitted dotnet/runtime#98531 so that we can move towards deleting the offending alpine 3.16 image. |
@radical @radekdoulik I changed the versions to pin things to the last working versions for 18.04. That being said, I can't see a place that uses the 18.04 webassembly image. Can it be removed? the node version and dependencies are no longer maintained. |
No description provided.