Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about NullReferenceException in ConfigurationRoot ctor #9665

Merged
merged 7 commits into from
Mar 7, 2024

Conversation

@moojek moojek requested a review from a team as a code owner March 1, 2024 15:26
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 1, 2024
@moojek moojek closed this Mar 1, 2024
@moojek moojek reopened this Mar 1, 2024
@moojek
Copy link
Contributor Author

moojek commented Mar 1, 2024

Sorry for close and reopen, I must've misclicked something.

This comment was marked as outdated.

Copy link

Learn Build status updates of commit ab35a84:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationRoot.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren
Copy link
Contributor

gewarren commented Mar 6, 2024

Tagging @dotnet/area-extensions-configuration

Copy link
Member

@tarekgh tarekgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It is showing some diff in line 239 which unclear to me what exactly change there. Will be good to revert this change.

This reverts accidental changes from commit ab35a84.
@moojek
Copy link
Contributor Author

moojek commented Mar 6, 2024

Hi, sorry for the hassle. Maybe it was some autocrlf from git, I don't know - certainly not my personal change. I already reverted it.

Copy link

Learn Build status updates of commit 053e95a:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationRoot.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@tarekgh
Copy link
Member

tarekgh commented Mar 7, 2024

@moojek looks you reverted the wrong part of the doc :-)

@moojek
Copy link
Contributor Author

moojek commented Mar 7, 2024

That's what doing it at 1 am in bed does, huh? I'll correct it later today

@moojek
Copy link
Contributor Author

moojek commented Mar 7, 2024

It was ridiculously hard to correct, but I think all good now @tarekgh :)

Copy link

Learn Build status updates of commit c00f458:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationRoot.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 7f94e3f:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/ConfigurationRoot.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@tarekgh tarekgh merged commit da37daa into dotnet:main Mar 7, 2024
3 checks passed
@tarekgh
Copy link
Member

tarekgh commented Mar 7, 2024

Thanks @moojek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Extensions-Configuration community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants