-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add information about NullReferenceException in ConfigurationRoot ctor #9665
Conversation
Sorry for close and reopen, I must've misclicked something. |
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit ab35a84: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Tagging @dotnet/area-extensions-configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
It is showing some diff in line 239 which unclear to me what exactly change there. Will be good to revert this change.
This reverts accidental changes from commit ab35a84.
Hi, sorry for the hassle. Maybe it was some autocrlf from git, I don't know - certainly not my personal change. I already reverted it. |
Learn Build status updates of commit 053e95a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
@moojek looks you reverted the wrong part of the doc :-) |
That's what doing it at 1 am in bed does, huh? I'll correct it later today |
It was ridiculously hard to correct, but I think all good now @tarekgh :) |
Learn Build status updates of commit c00f458: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Learn Build status updates of commit 7f94e3f: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thanks @moojek! |
Summary
As in title. Source: https://github.com/dotnet/runtime/blob/049da221a7f0e38eb92ef72fe0611b9b72e513da/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationRoot.cs