Remove superfluous empty lines #9653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
dotnet-policy-service
bot
added
the
community-contribution
Rageking8
commented
Feb 28, 2024
|
Unsure how to proceed given the large number of "missing project" CI errors. |
|
Hi @Rageking8
For any of the samples that build on .NET 8, these can be fixed by adding a default For projects that need the framework, and require Visual Studio to build, you'll need to create a Visual Studio project file in the same folder, and add a
|
|
All the errors we care about will be fixed by this PR: #9677. (The other errors are for legacy API code examples.) |
|
@Rageking8 Can you fix the conflicts? |
|
I removed the conflicted changes, but the CI will still fail unless we merge main into this branch. (I don't have the repo cloned on my local machine, so its harder to perform this action) |
|
Learn Build status updates of commit b4f1d3a: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
|
Learn Build status updates of commit 11d284e: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
|
Learn Build status updates of commit b1ddef7: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. For any questions, please:
|
@gewarren The conflicts and CI errors are resolved. |
BillWagner
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
THis LGTM.
Thanks for all the work @Rageking8
I'll wait to merge until @gewarren has a chance to review as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly removed leading (just after the start of the snippet) empty lines as those are rendered and make the code snippet unnecessarily long (especially on mobile or smaller viewports). There are also some excess empty lines in between that are removed.