Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp examples for SortedList (#6862) #9637

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

gsomix
Copy link
Contributor

@gsomix gsomix commented Feb 24, 2024

Summary

Added F# examples for SortedList<'TKey, 'TValue> type.

Fixes #6862

@gsomix gsomix requested a review from a team as a code owner February 24, 2024 21:05
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 24, 2024
Copy link

Learn Build status updates of commit ed18f98:

⚠️ Validation status: warnings

File Status Preview URL Details
[xml/System.Collections.Generic/SortedList2.xml](https://github.com/gsomix/dotnet-api-docs/blob/fix/6862-sortedlist-fsharp/xml/System.Collections.Generic/SortedList2.xml) ⚠️Warning View Details
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/remarks.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/source.fs ✅Succeeded View

[xml/System.Collections.Generic/SortedList2.xml](https://github.com/gsomix/dotnet-api-docs/blob/fix/6862-sortedlist-fsharp/xml/System.Collections.Generic/SortedList2.xml)

  • Line 0, Column 0: [Warning: invalid-code] The code snippet "~/snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/source.cs" could not be found.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gsomix gsomix force-pushed the fix/6862-sortedlist-fsharp branch from ed18f98 to e6e22f7 Compare February 25, 2024 17:15
Copy link

Learn Build status updates of commit e6e22f7:

✅ Validation status: passed

File Status Preview URL Details
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/remarks.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/source.fs ✅Succeeded View
xml/System.Collections.Generic/SortedList`2.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

BillWagner
BillWagner previously approved these changes Feb 26, 2024
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsomix

This is a valuable addition. I'll :shipit: now.

@BillWagner BillWagner dismissed their stale review February 26, 2024 15:23

CI build failed.

@BillWagner
Copy link
Member

Hi @gsomix

I just dismissed my review because the CI build failed on the code files. Can you update the samples so they compile correctly? Then, this is ready to merge.

@gsomix gsomix force-pushed the fix/6862-sortedlist-fsharp branch from e6e22f7 to 759e514 Compare February 26, 2024 20:13
@gsomix
Copy link
Contributor Author

gsomix commented Feb 26, 2024

Hi @BillWagner

Yeah, I forgot to push the latest changes. Everything should work now.

Copy link

Learn Build status updates of commit 759e514:

✅ Validation status: passed

File Status Preview URL Details
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/fs.fsproj ✅Succeeded
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/remarks.fs ✅Succeeded View
snippets/fsharp/System.Collections.Generic/SortedListTKey,TValue/Overview/source.fs ✅Succeeded View
xml/System.Collections.Generic/SortedList`2.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsomix

I'll merge this now.

@BillWagner BillWagner merged commit cbea657 into dotnet:main Feb 27, 2024
3 checks passed
@gsomix gsomix deleted the fix/6862-sortedlist-fsharp branch February 28, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No example code for F# language, defaults to showing C#
2 participants