Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct None enum description #9632

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

joynoele
Copy link
Contributor

@joynoele joynoele commented Feb 22, 2024

Correct erroneous documentation description of the Enum CngExportPolicies.None option.
Correction text is kept as simple as possible. Conclusion reached via my own testing, the two open issues with the same question, and reply from reply from member @bartonjs:

CngExportPolicy.None is "non-exportable". If you're creating a key with CngKey.Create and don't specify an export policy explicitly, the key will be non-exportable.

Fixes #5076
Fixes #9159

@joynoele joynoele requested a review from a team as a code owner February 22, 2024 17:35
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 22, 2024
Copy link

Learn Build status updates of commit d7eb604:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Security.Cryptography/CngExportPolicies.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-System.Security Issues related to security practices for .NET developers. label Feb 23, 2024
@BillWagner BillWagner requested a review from bartonjs February 23, 2024 14:18
@BillWagner
Copy link
Member

This looks right to me, but adding @bartonjs to confirm.

@joynoele
Copy link
Contributor Author

joynoele commented Mar 5, 2024

bumping this PR.

@bartonjs bartonjs merged commit 19bfe24 into dotnet:main Mar 5, 2024
3 checks passed
@joynoele joynoele deleted the fix-CngExportPolicies-none branch August 20, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Security Issues related to security practices for .NET developers. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
3 participants