Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #9622

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Merge main into live #9622

merged 4 commits into from
Feb 20, 2024

Conversation

dotnet-policy-service[bot]
Copy link
Contributor

Please don't squash-merge this PR.

Fast-Nick and others added 2 commits February 15, 2024 20:01
Return type is a regular C# bool, not SqlBoolean.
Update INullable.xml remove SqlBoolean from <value> for IsNull property
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 16, 2024
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link

Learn Build status updates of commit 551f9ca:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.SqlTypes/INullable.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 02cd139:

✅ Validation status: passed

File Status Preview URL Details
docfx.json ✅Succeeded
xml/System.Data.SqlTypes/INullable.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

The `null != ...` check looked strange, as it's usually written the other way around in C#. Rather than have a null check, just change this to a type check.
Copy link

Learn Build status updates of commit 506c290:

✅ Validation status: passed

File Status Preview URL Details
docfx.json ✅Succeeded
xml/System.Data.SqlTypes/INullable.xml ✅Succeeded View
xml/System.Security.Claims/ClaimsPrincipal.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner BillWagner merged commit d4d3589 into live Feb 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants