-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Activator.xml #9409
Update Activator.xml #9409
Conversation
Learn Build status updates of commit 6412b81: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
xml/System/Activator.xml
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Fix bad XML
Use `T:` prefix for type refs
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit 556b30a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Thanks @colejohnson66. Yes, can you remove it from the remarks. Also, it looks like there are a couple more overloads that should be updated with this return type. |
Update remaining method return notes and remove remarks about null.
Learn Build status updates of commit 04b71c6: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Document (in the "returns" section) when
Activator.CreateInstance
can returnnull
. This information is currently documented in the remarks, but, as remarks are placed below exceptions and examples, it's easy to miss.Fixes #9407
Question
Should the note of
null
returns be removed from the remarks area?