Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: AssemblyVersion not removed even when the member is removed from that assembly. #9400

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

huangmin-ms
Copy link
Contributor

@huangmin-ms huangmin-ms commented Oct 24, 2023

@gewarren, this diff is generated by the fix of bug https://dev.azure.com/ceapex/Engineering/_workitems/edit/896871
We did a few checks on the diffs and they are expected. Please help to review, thanks!

Example1: ConfigurationManager.xml

Microsoft.Extensions.Configuration.IConfigurationBuilder.Sources: in version 7.0.00, it is not an EII anymore. So it is removed.

Example2: ServiceCollection.xml.

The constructor method was moved from Microsoft.Extensions.DependencyInjection to Microsoft.Extensions.DependencyInjection.Abstractions in version 6.0.0.0

image

@gewarren gewarren enabled auto-merge (squash) October 24, 2023 02:40
@learn-build-service-prod
Copy link

Learn Build status updates of commit 68a84f1:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/System.ServiceModel.Channels/HttpRequestMessageProperty.xml ⚠️Warning View Details
xml/System.ServiceModel.Channels/HttpResponseMessageProperty.xml ⚠️Warning View Details
xml/Microsoft.Extensions.Configuration/ConfigurationManager.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/OptionsBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.DependencyInjection/ServiceCollection.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/SystemdHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Hosting/WindowsServiceLifetimeHostBuilderExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Logging/ILoggingBuilder.xml ✅Succeeded View
xml/Microsoft.Extensions.Primitives/InplaceStringBuilder.xml ✅Succeeded View
xml/Microsoft.JScript/JScriptException.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptKeyHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptProviderHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeNCryptSecretHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeRegistryHandle.xml ✅Succeeded View
xml/Microsoft.Win32.SafeHandles/SafeX509ChainHandle.xml ✅Succeeded View
xml/Microsoft.Win32/FileDialog.xml ✅Succeeded View
xml/System.Buffers.Text/Base64.xml ✅Succeeded View
xml/System.Collections.Generic/KeyedByTypeCollection`1.xml ✅Succeeded View
xml/System.Collections.Generic/SynchronizedCollection`1.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/AssociatedMetadataTypeTypeDescriptionProvider.xml ✅Succeeded View
xml/System.ComponentModel.DataAnnotations/MetadataTypeAttribute.xml ✅Succeeded View
xml/System.ComponentModel.Design/DesignerVerbCollection.xml ✅Succeeded View
xml/System.ComponentModel/CollectionConverter.xml ✅Succeeded View
xml/System.Data.Odbc/OdbcConnection.xml ✅Succeeded View

This comment lists only the first 25 files in the pull request.

xml/System.ServiceModel.Channels/HttpRequestMessageProperty.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.ServiceModel.Channels.IMergeEnabledMessageProperty'.

xml/System.ServiceModel.Channels/HttpResponseMessageProperty.xml

  • Line 0, Column 0: [Warning: xref-not-found] Cross reference not found: 'System.ServiceModel.Channels.IMergeEnabledMessageProperty'.

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 8a1b0a0 into main Oct 24, 2023
@gewarren gewarren deleted the diff-1023 branch October 24, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants