Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port System.Net.Http docs for HttpRequestError and metrics additions #9305

Merged
merged 8 commits into from
Sep 18, 2023

Conversation

antonfirsov
Copy link
Member

Contributes to dotnet/runtime#88569.

@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to dotnet/runtime#88569.

Author: antonfirsov
Assignees: antonfirsov
Labels:

area-System.Net.Http

Milestone: -

@antonfirsov antonfirsov requested a review from a team as a code owner September 18, 2023 15:30
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for you to consider.

xml/ns-System.Net.Http.Metrics.xml Outdated Show resolved Hide resolved
@learn-build-service-prod

This comment was marked as outdated.

xml/System.Net.Http/HttpIOException.xml Outdated Show resolved Hide resolved
xml/System.Net.Http/HttpRequestError.xml Outdated Show resolved Hide resolved
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit 6f0991e:

✅ Validation status: passed

File Status Preview URL Details
xml/ns-System.Net.Http.Metrics.xml ✅Succeeded View
xml/System.Net.Http.Metrics/HttpMetricsEnrichmentContext.xml ✅Succeeded View
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View
xml/System.Net.Http/HttpIOException.xml ✅Succeeded View
xml/System.Net.Http/HttpMethod.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestError.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestException.xml ✅Succeeded View
xml/System.Net.Http/HttpRequestOptions.xml ✅Succeeded View
xml/System.Net.Http/SocketsHttpHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@carlossanlop carlossanlop merged commit ea6147b into dotnet:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants