-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port System.Net.Sockets APIs #9303
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsSummaryContributes to dotnet/runtime#88569.
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some suggestions for you to consider.
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Co-authored-by: Carlos Sánchez López <[email protected]>
Small suggestion: You can apply multiple suggestions in bulk if you go to the Files tab and add each one of the suggestions to the same commit. That way the CI only runs one (because there is one commit). If suggestions get applied directly in the Conversation tab, each suggestion creates a commit, and the CI runs once for each one of those commits, so we need to wait much longer to get the final result. |
Thanks for the suggestion! Generally, I'm doing the same thing as you suggested but there was something wrong with that option and it didn't work, that's why I did it in this way. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Learn Build status updates of commit f30bf11: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Summary
Contributes to dotnet/runtime#88569.