Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port System.Net.Sockets APIs #9303

Merged
merged 13 commits into from
Sep 18, 2023
Merged

Conversation

liveans
Copy link
Member

@liveans liveans commented Sep 18, 2023

Summary

Contributes to dotnet/runtime#88569.

@liveans liveans requested a review from gewarren September 18, 2023 14:35
@liveans liveans self-assigned this Sep 18, 2023
@liveans liveans requested a review from a team as a code owner September 18, 2023 14:35
@ghost
Copy link

ghost commented Sep 18, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Contributes to dotnet/runtime#88569.

Author: liveans
Assignees: liveans
Labels:

area-System.Net.Sockets

Milestone: -

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions for you to consider.

xml/System.Net.Sockets/LingerOption.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/LingerOption.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/LingerOption.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/Socket.xml Show resolved Hide resolved
xml/System.Net.Sockets/Socket.xml Show resolved Hide resolved
xml/System.Net.Sockets/Socket.xml Show resolved Hide resolved
xml/System.Net.Sockets/Socket.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/UnixDomainSocketEndPoint.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/UnixDomainSocketEndPoint.xml Outdated Show resolved Hide resolved
xml/System.Net.Sockets/UnixDomainSocketEndPoint.xml Outdated Show resolved Hide resolved
@carlossanlop
Copy link
Member

Small suggestion: You can apply multiple suggestions in bulk if you go to the Files tab and add each one of the suggestions to the same commit. That way the CI only runs one (because there is one commit). If suggestions get applied directly in the Conversation tab, each suggestion creates a commit, and the CI runs once for each one of those commits, so we need to wait much longer to get the final result.

@liveans
Copy link
Member Author

liveans commented Sep 18, 2023

Small suggestion: You can apply multiple suggestions in bulk if you go to the Files tab and add each one of the suggestions to the same commit. That way the CI only runs one (because there is one commit). If suggestions get applied directly in the Conversation tab, each suggestion creates a commit, and the CI runs once for each one of those commits, so we need to wait much longer to get the final result.

Thanks for the suggestion! Generally, I'm doing the same thing as you suggested but there was something wrong with that option and it didn't work, that's why I did it in this way.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

xml/System.Net.Sockets/Socket.xml Show resolved Hide resolved
@liveans liveans enabled auto-merge September 18, 2023 19:50
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod
Copy link

Learn Build status updates of commit f30bf11:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Sockets/LingerOption.xml ✅Succeeded View
xml/System.Net.Sockets/Socket.xml ✅Succeeded View
xml/System.Net.Sockets/TcpListener.xml ✅Succeeded View
xml/System.Net.Sockets/UnixDomainSocketEndPoint.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@liveans liveans merged commit 651a244 into dotnet:main Sep 18, 2023
@liveans liveans deleted the sockets-namespace-doc-port branch September 18, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants