Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional tweaks to new System.Data async APIs #3077

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Additional tweaks to new System.Data async APIs #3077

merged 1 commit into from
Sep 6, 2019

Conversation

roji
Copy link
Member

@roji roji commented Aug 26, 2019

  • Fixes to PrepareAsync
  • Made cancellation token description more consistent and added note where default values are present.
  • Changed default value for cancellation tokens to be CancellationToken.None instead of null

/cc @divega @mairaw @carlossanlop

@roji roji requested a review from stevestein as a code owner August 26, 2019 18:24
@carlossanlop carlossanlop added 🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews labels Aug 26, 2019
@carlossanlop carlossanlop added this to the August 2019 milestone Aug 26, 2019
carlossanlop
carlossanlop requested changes Aug 26, 2019
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly addressing this, @roji. I added a few suggestions for the CancellationToken. I suspect all of them have the default value None, but a few of the summaries did not mention it. Is this assumption correct?
Also, the MemberSignatures should not be updated manually. We should ask @safern and @mairaw to help with this.

@roji
Copy link
Member Author

roji commented Aug 26, 2019

@carlossanlop thanks for the comments - I've replied above. At least for the methods you've mentioned, there's indeed no default value for the cancellation token.

Let's wait for the replies on manual updates for these XMLs.

Please feel free to ping me or send an email directory on any System.Data doc issue.

@roji
Copy link
Member Author

roji commented Aug 26, 2019

@carlossanlop makes sense. Have resolved the comments, let me know if anything else is needed from my side.

@roji
Additional tweaks to new System.Data async APIs
a2b77ca 
* Fixes to PrepareAsync
* Made cancellation token description more consistent and added
  note where default values are present.
* Changed default value for cancellation tokens to be
  CancellationToken.None instead of null
@roji roji force-pushed the SystemDataAsyncLastStuff branch from eee034b to a2b77ca Compare August 27, 2019 08:17
rpetrusha
rpetrusha approved these changes Aug 27, 2019
View reviewed changes
Copy link

@rpetrusha rpetrusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this ready to merge?

@roji
Copy link
Member Author

roji commented Aug 28, 2019 •
edited
Loading

Yep, ready to merge from my side.

@rpetrusha
Copy link

@carlossanlop, do you want to take a look and approve if this is ready to merge?

carlossanlop
carlossanlop approved these changes Aug 31, 2019
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, @rpetrusha. Approved.

@rpetrusha rpetrusha merged commit c803353 into dotnet:master Sep 6, 2019
@mairaw mairaw mentioned this pull request Sep 7, 2019
Merged
@mairaw mairaw removed the waiting-on-reviews Indicates PRs that cannot be merged because of the lack of reviews label Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divega divega divega left review comments

@rpetrusha rpetrusha rpetrusha approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@stevestein stevestein Awaiting requested review from stevestein

@mairaw mairaw Awaiting requested review from mairaw

Assignees

@roji roji

Labels
🏁 Release: .NET Core 3.0 :checkered_flag: Release: .NET Core 3.0 new-content Indicates PRs that contain new articles
Projects
None yet
Milestone
August 2019
Development

Successfully merging this pull request may close these issues.
5 participants
@roji @rpetrusha @carlossanlop @divega @mairaw