Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about allowing out of order metadata properties #10587

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

gewarren
Copy link
Contributor

Contributes to dotnet/docs#42592.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json

Copy link

Learn Build status updates of commit 8e7163b:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/ReferenceHandler.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Member

@eiriktsarpalis eiriktsarpalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to also include mention of this feature in the polymorphism document?

https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/polymorphism?pivots=dotnet-8-0

Polymorphism is the primary motivator for introducing this feature (e.g. because you're reading data off an external API that happens to place the $type discriminator in the middle of an object.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

@gewarren
Copy link
Contributor Author

Would it make sense to also include mention of this feature in the polymorphism document?

https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/polymorphism?pivots=dotnet-8-0

Polymorphism is the primary motivator for introducing this feature (e.g. because you're reading data off an external API that happens to place the $type discriminator in the middle of an object.

Yes, I will add it there separately too.

@gewarren gewarren merged commit e4006f0 into main Oct 19, 2024
4 checks passed
@gewarren gewarren deleted the gewarren-patch-14 branch October 19, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants