Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port System.Formats.Asn1 docs for .NET 9 #10576

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

vcsjones
Copy link
Member

A new API was introduced in .NET 9, {Try}DecodeLength ref. It's not clear to me why this was not flagged as a package that needed to be updated, but we never ported the docs for this as far as I can tell.

Regardless, this ports the documentation for System.Formats.Asn1.

/cc @bartonjs @carlossanlop

@gewarren
Copy link
Contributor

@vcsjones If this was set to true, the docs would have been pulled in automatically during the CI updates: https://github.com/dotnet/runtime/blob/def5e3240bdee3ee37ba22c41c840bbf431c4b15/src/libraries/System.Formats.Asn1/src/System.Formats.Asn1.csproj#L7

xml/System.Formats.Asn1/AsnDecoder.xml Outdated Show resolved Hide resolved
xml/System.Formats.Asn1/AsnDecoder.xml Outdated Show resolved Hide resolved
xml/System.Formats.Asn1/AsnDecoder.xml Outdated Show resolved Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Copy link

Learn Build status updates of commit 6729d89:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Formats.Asn1/AsnDecoder.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 3f3b0fd:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Formats.Asn1/AsnDecoder.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@gewarren gewarren merged commit 76b6f0e into dotnet:main Oct 16, 2024
4 checks passed
@vcsjones vcsjones deleted the decodelength-docs branch October 16, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants