Rewrite of the Azure Cosmos DB articles #2324
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Dec 19, 2024
| .OfType<CosmosDBAccount>() | ||
| .Single(); | ||
|
|
||
| cosmosDbAccount.Kind = CosmosDBAccountKind.MongoDB; |
There was a problem hiding this comment.
Does this work when you use the client integration?
There was a problem hiding this comment.
I'm not certain, but why wouldn't it?
davidfowl
reviewed
Dec 19, 2024
IEvangelist
changed the title
dotnet-policy-service
bot
added
the
okr-quality
davidfowl
reviewed
Dec 19, 2024
| @@ -129,6 +129,9 @@ var cosmos = builder.AddAzureCosmosDB("cosmos-db") | |||
|
|
|||
| When you call `AddDatabase`, it configures your Cosmos DB resources to have a database named `db`. The database is created in the Cosmos DB account that's represented by the `AzureCosmosDBResource` that you added earlier. The database is a logical container for collections and users. For more information, see [Databases, containers, and items in Azure Cosmos DB](/azure/cosmos-db/resource-model). | |||
|
|
|||
| > [!NOTE] | |||
| > When using the `AddDatabase` API to add a database to an Azure Cosmos DB resource, if you're running the emulator, the database isn't actually created in the emulator. This API is intended to include a database in the [Bicep generated](#generated-provisioning-bicep) by the provisioning infrastructure. | |||
There was a problem hiding this comment.
This is true for all database resources
There was a problem hiding this comment.
That's really good to know... it's certainly confusing, I'll update the other places to make this obvious to consumers. It would be AMAZING if the triple slash comments said something about that.
There was a problem hiding this comment.
Aspire.Microsoft.Data.SqlClient-AddDatabasedoesn't create database? aspire#4813- Aspire SqlServer integration doesn't actually create a database when calling AddDatabase aspire#6863
We're going to end up fixing it so that it does create the database.
BillWagner
approved these changes
Dec 20, 2024
when you're ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite of the Azure Cosmos DB.
Fixes #2307
Internal previews