New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify `isCoverPage` check conditions #10453

Merged

yufeih merged 1 commit into dotnet:main from filzrev:fix-issue-10414

Dec 14, 2024

Contributor

filzrev commented Dec 11, 2024

This PR intended to fix issue reported at #10414

I've added #10416 before to fix coverPage rendering issue.
But isCoverPage check logics is not sufficient for relative path.

What's changed in this PR

Normalize page URL before comparing to coverPage URL.
Add settings for seed projects to exclude pdf/*.html files from contents.


          fix: modify isCoverPage check conditions

e1eb60f

yufeih approved these changes

View reviewed changes

yufeih added the bug-fix label

yufeih merged commit 445113c into dotnet:main

7 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix