-
Notifications
You must be signed in to change notification settings - Fork 4.9k
.NET 10 P3 - SDK Notes #9822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
.NET 10 P3 - SDK Notes #9822
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5bd7228
SDK Start
jamesmontemagno 7e33efd
Add first draft of SDK features for p3
baronfel 3db67d5
Update release-notes/10.0/preview/preview3/sdk.md
baronfel eed8eb6
Update release-notes/10.0/preview/preview3/sdk.md
baronfel c48a43b
Update release-notes/10.0/preview/preview3/sdk.md
jamesmontemagno 0e2f1da
Update release-notes/10.0/preview/preview3/sdk.md
jamesmontemagno File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Youssef1313 / @mariam-abdulla did you manage to merge the change that understands the new format without the
:
? I saw remarks about the change being in preview4 in multiple places.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the
:
-based impl work? I'm concerned with putting something in the p3 relnotes and then changing it in p4 - folks often just google and copy-paste.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:
violates TOML and is going to P3. Unfortunately, we already documented it and it's shipping in P3.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the change was merged.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather just not talk about the non-compliant feature in p3 if a fix and future-forward version is coming in a month. Similar logic to what Damian was saying with regards to dotnet-run singlefile. You get one chance to make a first impression - it should be correct and complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baronfel So you mean drop it from release notes?
We have had it documented in
dotnet/docs
repo though and have seen few users playing with it already on Preview 2 😕There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant merged in code that will be released in preview3.
I assume "Microsoft.Testing.Platform" would NOT work with preview3 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted to the working p3 form.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Microsoft.Testing.Platform" should work with preview 3.
https://github.com/dotnet/sdk/blob/release/10.0.1xx-preview3/src/Cli/dotnet/commands/dotnet-test/CliConstants.cs#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edit: actually fixed the things -
Microsoft.Testing.Platform
anddotnet.test:runner
for p3