Update CODEOWNERS to include doc writers and reduce duplication #60017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds @Rick-Anderson and @tdykstra as CODEOWNERS for `/**/PublicAPI.*Shipped.txt`, so they get notified for any PR that adds new API so they can review the doc comments. Alternatively, they could join @aspnet-api-review, but that may be used for more than just PRs. I also took the opportunity to remove some redundancy with the assumption that the [last matched pattern wins](https://graphite.dev/guides/in-depth-guide-github-codeowners#patterns-and-precedence-in-the-codeowners-file). If we find that's not the case, we can revert that part later and add @Rick-Anderson and @tdykstra to all the relevant lines.
halter73
requested review from
tdykstra,
captainsafia,
Rick-Anderson and
BrennanConroy
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
@wtgodbe GitHub is warning me that the CODEOWNERS file doesn't validate because @dotnet-maestro-bot doesn't have write access to this repo. Should I just remove references to the bot from the file?
|
Yeah just remove them, dotnet-maestro-bot has been replaced by dotnet-maestro, which reviews its own PRs anyways, as per |
danmoseley
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds @Rick-Anderson and @tdykstra as CODEOWNERS for
/**/PublicAPI.*Shipped.txt, so they get notified for any PR that adds new API so they can review the doc comments.Alternatively, they could join @dotnet/aspnet-api-review, but that may be used for more than just PRs.
I also took the opportunity to remove some redundancy with the assumption that the last matched pattern wins. If we find that's not the case, we can revert that part later and add @Rick-Anderson and @tdykstra to all the relevant lines.