Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContinueOnError in windows local development job #59037

Merged
merged 1 commit into from
Nov 18, 2024
Merged

ContinueOnError in windows local development job #59037

merged 1 commit into from
Nov 18, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Nov 18, 2024

The windows local development job is extremely flaky right now due to #58957. Continue the job on error until that issue is resolved

@wtgodbe wtgodbe requested a review from a team as a code owner November 18, 2024 22:06
@wtgodbe wtgodbe requested a review from javiercn November 18, 2024 22:06
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Nov 18, 2024
@adityamandaleeka
Copy link
Member

Does this need to go through a full CI? It seems safe enough to merge IMO since it unblocks other things.

@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 18, 2024

Does this need to go through a full CI? It seems safe enough to merge IMO since it unblocks other things.

I'd like to see the local dev job behave how I expect it to first, I'll merge as soon as that's done

@wtgodbe wtgodbe enabled auto-merge (squash) November 18, 2024 22:56
@wtgodbe
Copy link
Member Author

wtgodbe commented Nov 18, 2024

Yup, tests failed but the job was yellow. Force merging.

@wtgodbe wtgodbe disabled auto-merge November 18, 2024 23:48
@wtgodbe wtgodbe merged commit f87c902 into main Nov 18, 2024
25 of 27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/coe branch November 18, 2024 23:48
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants