Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unquarantine fixed tests that have not failed in 30 days #57978

Merged
merged 8 commits into from
Oct 4, 2024
Merged

Unquarantine fixed tests that have not failed in 30 days #57978

merged 8 commits into from
Oct 4, 2024

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Sep 20, 2024 •
edited
Loading

Fixes #54754
Fixes #54447
Fixes #57153
Fixes #57259

#47967 was already closed, but the tests were still quarantined.

@halter73 halter73 requested a review from a team as a code owner September 20, 2024 01:27
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Sep 20, 2024
halter73
halter73 commented Sep 20, 2024
View reviewed changes
src/Components/test/E2ETest/Tests/ThreadingAppTest.cs
@@ -28,14 +28,12 @@ protected override void InitializeAsyncCore()
}

[Fact]
[QuarantinedTest("https://github.com/dotnet/aspnetcore/issues/54754")]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MackinnonBuck I saw you mention in this issue that the test failures may be caused by dotnet/runtime#106788 which is still open.

However, you still kept the test-fixed label on the issue and I don't see any ThreadingAppTests failing at https://dev.azure.com/dnceng-public/public/_test/analytics?definitionId=84&contextType=build. Do you think these are safe to unquarantine?

@halter73
Revert "Unquarantine #57259"
bb76b9b 
This reverts commit efbbf3b.
@halter73
Copy link
Member Author

I didn't look at https://dev.azure.com/dnceng-public/public/_test/analytics?definitionId=84&contextType=build closely enough. Both VerifyCountersFireWithCorrectValues and EventCountersAndMetricsValues have been failed in the last 30 days. Fortunately, the PR checks caught the failure.

I requarantined both tests, and I'll remove the test-fixed label from #57259 and keep it open.

@halter73 halter73 enabled auto-merge (squash) September 20, 2024 20:50
@halter73 halter73 mentioned this pull request Sep 22, 2024
Open
This was referenced Sep 23, 2024
Open
Open
Open
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Sep 30, 2024
@halter73 halter73 merged commit 870eec2 into main Oct 4, 2024
27 checks passed
@halter73 halter73 deleted the halter73/unquarantine branch October 4, 2024 00:06
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@MackinnonBuck MackinnonBuck Awaiting requested review from MackinnonBuck

Assignees
No one assigned
Labels
area-blazor Includes: Blazor, Razor Components pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun
Projects
None yet
Milestone
10.0-preview1
2 participants
@halter73 @JamesNK