Skip to content

Use Arcade's DownloadFiles task #46039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Use Arcade's DownloadFiles task #46039

merged 5 commits into from
Jan 11, 2023

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Jan 11, 2023

Cherry-pick changes from #44949. Gets rid of old property DotnetAssetRootUrl and uses Arcade's task instead of our own.

CC @BrennanConroy

mmitche and others added 5 commits January 11, 2023 12:20
- was still trying to use our version
- don't try internal download location in public builds
- use two targets to make Product.targets more readable
@wtgodbe wtgodbe requested a review from mmitche January 11, 2023 20:22
@wtgodbe wtgodbe requested review from a team and dougbu as code owners January 11, 2023 20:22
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 11, 2023
@wtgodbe wtgodbe merged commit 243f90d into dotnet:main Jan 11, 2023
@wtgodbe wtgodbe deleted the wtgodbe/PortAssetRootStuff branch January 11, 2023 23:33
@ghost ghost added this to the 8.0-preview1 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants