Skip to content

Fix H3 Client Cert tests #42346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix H3 Client Cert tests #42346

merged 1 commit into from
Jun 22, 2022

Conversation

Tratcher
Copy link
Member

Fixes #41894 - These tests covered prior behavior before the client cert feature was fully implemented in runtime. They've been updated to reflect the new behavior.

  • ClientCertificate_Allow_NotAvailable_Optional
  • ClientCertificate_Required_NotSent_ConnectionAborted

#35070 improvements. These are the last two tests for 35070, marking as test-fixed.

  • POST_ServerAbort_ClientReceivesAbort has been passing 100% and is being unquarantined.
  • ClientCertificate_AllowOrRequire_Available_Invalid_Refused fixed by properly draining/disposing the response.

@Tratcher Tratcher self-assigned this Jun 22, 2022
@ghost ghost added the area-runtime label Jun 22, 2022
@Tratcher Tratcher enabled auto-merge (squash) June 22, 2022 17:29
@Tratcher Tratcher merged commit 7ae0d9f into dotnet:main Jun 22, 2022
@Tratcher Tratcher deleted the tratcher/h3_clientcert branch June 22, 2022 22:28
@ghost ghost added this to the 7.0-preview6 milestone Jun 22, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@JamesNK JamesNK Awaiting requested review from JamesNK JamesNK is a code owner

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
7.0-preview6
Development

Successfully merging this pull request may close these issues.

Quarantine H3 Client Cert optional tests
3 participants
@Tratcher @BrennanConroy @amcasey