Skip to content

Quarantine H3 Client Cert optional tests #41894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tratcher opened this issue May 27, 2022 · 1 comment · Fixed by #42346
Closed

Quarantine H3 Client Cert optional tests #41894

Tratcher opened this issue May 27, 2022 · 1 comment · Fixed by #42346
Assignees
@Tratcher
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3 test-failure
Milestone
7.0-preview7

Comments

@Tratcher
Copy link
Member

Failing Test(s)

  • ClientCertificate_Allow_NotAvailable_Optional
  • ClientCertificate_Required_NotSent_ConnectionAborted

dotnet/runtime#57308 was supposed to allow optional certificates, however the dependency update PR that consumed this change still fails both tests. I tried updating the tests to reflect the new feature, but it doesn't seem to be working as expected. Quarantining to unblock the dependency update. #41866
@Tratcher Tratcher self-assigned this May 27, 2022
@adityamandaleeka adityamandaleeka added this to the Test failures milestone Jun 1, 2022
@dougbu dougbu mentioned this issue Jun 3, 2022
Merged
@adityamandaleeka
Copy link
Member

Need to investigate the tests. Moving to preview 7.

Tratcher added a commit to Tratcher/aspnetcore that referenced this issue Jun 21, 2022
@Tratcher
Fix H3 Client Cert tests dotnet#41894
00e935e
@Tratcher Tratcher mentioned this issue Jun 22, 2022
Merged
Tratcher added a commit that referenced this issue Jun 22, 2022
@Tratcher
Fix H3 Client Cert tests #41894 (#42346)
7ae0d9f
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions HTTP3 test-failure
Projects
None yet
Milestone
7.0-preview7
Development

Successfully merging a pull request may close this issue.

Fix H3 Client Cert tests Tratcher/aspnetcore
3 participants
@adityamandaleeka @Tratcher @amcasey