Update comments

dotnet · Dec 5, 2023 · 4390e52 · 4390e52
1 parent 657ea60
commit 4390e52
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...etCore/WebApi/src/Asp.Versioning.Http/DependencyInjection/IServiceCollectionExtensions.cs b/...etCore/WebApi/src/Asp.Versioning.Http/DependencyInjection/IServiceCollectionExtensions.cs
@@ -153,8 +153,8 @@ LinkGenerator NewFactory( IServiceProvider serviceProvider )
         }
     }
 
-    // TODO: Remove in .NET 8.0
-    // REF: https://github.com/dotnet/aspnetcore/issues/45051
+    // TODO: Remove in .NET 9.0 or .NET 8.0 patch
+    // BUG: https://github.com/dotnet/aspnetcore/issues/52577
     private static void TryAddProblemDetailsRfc7231Compliance( IServiceCollection services )
     {
         var descriptor = services.FirstOrDefault( IsDefaultProblemDetailsWriter );

diff --git a/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Rfc7231ProblemDetailsWriter.cs b/src/AspNetCore/WebApi/src/Asp.Versioning.Http/Rfc7231ProblemDetailsWriter.cs
@@ -36,6 +36,9 @@ public bool CanWrite( ProblemDetailsContext context )
         {
             var acceptHeaderValue = acceptHeader[i];
 
+            // TODO: the logic is inverted in .NET 8. remove when fixed
+            // BUG: https://github.com/dotnet/aspnetcore/issues/52577
+            // REF: https://github.com/dotnet/aspnetcore/blob/release/8.0/src/Http/Http.Extensions/src/DefaultProblemDetailsWriter.cs#L38
             if ( acceptHeaderValue.IsSubsetOf( jsonMediaType ) ||
                  acceptHeaderValue.IsSubsetOf( problemDetailsJsonMediaType ) )
             {