Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WithEntrypoint on Containers #7577

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

eerhardt
Copy link
Member

Description

ACA infrastructure wasn't respecting the entrypoint on a ContainerResource. To fix this, set the container command to the entrypoint, if it is supplied.

Fix #7576

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

ACA infrastructure wasn't respecting the entrypoint on a ContainerResource. To fix this, set the container command to the entrypoint, if it is supplied.

Fix dotnet#7576

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@eerhardt eerhardt merged commit ac5199c into dotnet:main Feb 13, 2025
70 checks passed
@eerhardt eerhardt deleted the FixEntrypointACA branch February 13, 2025 00:47
@eerhardt
Copy link
Member Author

/backport to release/9.1

Copy link
Contributor

Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13298044433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PublishAsAzureContainerApp doesn't respect WithEntrypoint
2 participants