Follow-up fixes to RunAsExisting flow #7494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
captainsafia
commented
Feb 9, 2025
captainsafia
commented
- Inline Tags configuration for key vault
- Set resource scope in user-secrets config
- Remove fallback to default user group if existing resource group was not found
- Fix resolution of resource group name from parameter resource
davidfowl
reviewed
Feb 9, 2025
src/Aspire.Hosting.Azure/Provisioning/Provisioners/BicepProvisioner.cs
Outdated
Show resolved
Hide resolved
…ioner.cs Co-authored-by: David Fowler <[email protected]>
davidfowl
reviewed
Feb 9, 2025
| @@ -114,9 +114,9 @@ public override async Task GetOrCreateResourceAsync(AzureBicepResource resource, | |||
| existingResource.ResourceGroup is { } existingResourceGroup) | |||
| { | |||
| var existingResourceGroupName = existingResourceGroup is ParameterResource parameterResource | |||
| ? parameterResource.Name | |||
| ? parameterResource.Value | |||
There was a problem hiding this comment.
I knew it was doing this from the error I was getting
davidfowl
reviewed
Feb 9, 2025
| : (string)existingResourceGroup; | ||
| resourceGroup = await context.GetResourceGroup(existingResourceGroupName, resourceLogger, cancellationToken).ConfigureAwait(false); | ||
| resourceGroup = await context.Subscription.GetResourceGroupAsync(existingResourceGroupName, cancellationToken).ConfigureAwait(false); |
There was a problem hiding this comment.
Does this handle if the resource group doesn't exist?
There was a problem hiding this comment.
Depends on what you mean by handle. Before it would fallback to the default group. Now, it'll fail and you'll see something like this in the logs:
Provisioning sbemulator...
Error provisioning sbemulator.
Azure.RequestFailedException: Resource group 'rg-aspire-deploy-not-real' could not be found.
Status: 404 (Not Found)
ErrorCode: ResourceGroupNotFound
Content:
{"error":{"code":"ResourceGroupNotFound","message":"Resource group 'rg-aspire-deploy-not-real' could not be found."}}
davidfowl
approved these changes
Feb 9, 2025
github-actions
bot
added
the
area-app-model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.