Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear console logs from settings dialog #7490

Merged
merged 6 commits into from
Feb 10, 2025

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 9, 2025

Description

console-logs-settings-clear

Fixes #7488

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 22 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • src/Aspire.Dashboard/Resources/Dialogs.Designer.cs: Language not supported
  • src/Aspire.Dashboard/Resources/Dialogs.resx: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.cs.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.de.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.es.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.fr.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.it.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ja.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ko.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.pl.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.pt-BR.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ru.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.tr.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.zh-Hans.xlf: Language not supported
  • src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor: Evaluated as low risk

@JamesNK JamesNK force-pushed the jamesnk/console-logs-settings-clear branch from ed225f1 to 6e81442 Compare February 10, 2025 01:03
@JamesNK JamesNK merged commit 8c71a85 into main Feb 10, 2025
70 checks passed
@JamesNK JamesNK deleted the jamesnk/console-logs-settings-clear branch February 10, 2025 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear all button in settings should clear console logs
2 participants