Skip to content

Enabled all test projects except for workload tests #7483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 8, 2025
Merged

Enabled all test projects except for workload tests #7483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
021e624
Enabled all test projects except for workload tests
davidfowl Feb 8, 2025
008b12d
Test tweaks
davidfowl Feb 8, 2025
8b01e3f
Get dumps for crashes too
davidfowl Feb 8, 2025
7106291
More tweaks
davidfowl Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,8 @@ jobs:
name: Components.Common
- project: tests/Aspire.Confluent.Kafka.Tests/Aspire.Confluent.Kafka.Tests.csproj
name: Confluent.Kafka
# This is failing
# - project: tests/Aspire.Elastic.Clients.Elasticsearch.Tests/Aspire.Elastic.Clients.Elasticsearch.Tests.csproj
# name: Elastic.Clients.Elasticsearch
- project: tests/Aspire.Elastic.Clients.Elasticsearch.Tests/Aspire.Elastic.Clients.Elasticsearch.Tests.csproj
name: Elastic.Clients.Elasticsearch
- project: tests/Aspire.Keycloak.Authentication.Tests/Aspire.Keycloak.Authentication.Tests.csproj
name: Keycloak.Authentication
- project: tests/Aspire.Microsoft.Azure.Cosmos.Tests/Aspire.Microsoft.Azure.Cosmos.Tests.csproj
Expand Down Expand Up @@ -136,7 +135,6 @@ jobs:
- project: tests/Aspire.StackExchange.Redis.Tests/Aspire.StackExchange.Redis.Tests.csproj
name: StackExchange.Redis

# These are failing due to globalization issues
# Dashboard projects
- project: tests/Aspire.Dashboard.Components.Tests/Aspire.Dashboard.Components.Tests.csproj
name: Dashboard.Components
Expand All @@ -146,7 +144,18 @@ jobs:
# Playground project
- project: tests/Aspire.Playground.Tests/Aspire.Playground.Tests.csproj
name: Playground
# Add more projects as needed

# Schema generator project
- project: tests/ConfigurationSchemaGenerator.Tests/ConfigurationSchemaGenerator.Tests.csproj
name: ConfigurationSchemaGenerator

# Service discovery projects
- project: tests/Microsoft.Extensions.ServiceDiscovery.Tests/Microsoft.Extensions.ServiceDiscovery.Tests.csproj
name: Extensions.ServiceDiscovery
- project: tests/Microsoft.Extensions.ServiceDiscovery.Dns.Tests/Microsoft.Extensions.ServiceDiscovery.Dns.Tests.csproj
name: Extensions.ServiceDiscovery.Dns
- project: tests/Microsoft.Extensions.ServiceDiscovery.Yarp.Tests/Microsoft.Extensions.ServiceDiscovery.Yarp.Tests.csproj
name: Extensions.ServiceDiscovery.Yarp
steps:
- name: Checkout code
uses: actions/checkout@v4
Expand Down Expand Up @@ -191,11 +200,13 @@ jobs:
--logger "GitHubActions;summary.includePassedTests=true;summary.includeSkippedTests=true" \
--blame \
--blame-hang-timeout 7m \
--blame-crash \
--results-directory testresults \
--no-restore \
--no-build -- RunConfiguration.CollectSourceInformation=true

- name: Dump docker info
if: always()
run: |
docker container ls --all
docker volume ls
Expand Down
4 changes: 3 additions & 1 deletion tests/Aspire.Dashboard.Tests/Integration/Playwright/BrowserTokenAuthenticationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,12 @@ await RunTestAsync(async page =>
await submitButton.ClickAsync().DefaultTimeout();

// Assert
const int pageVisibleTimeout = 10000;

await Assertions
.Expect(page.GetByText("Invalid token"))
.ToBeVisibleAsync()
.DefaultTimeout();
.DefaultTimeout(pageVisibleTimeout);
});
}

Expand Down
1 change: 1 addition & 0 deletions tests/Aspire.Elastic.Clients.Elasticsearch.Tests/AspireElasticClientExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ public void CanAddClientFromEncodedConnectionString()

[Fact]
[RequiresDocker]
[ActiveIssue("https://github.com/dotnet/aspire/issues/7452")]
public void ElasticsearchInstrumentationEndToEnd()
{
RemoteExecutor.Invoke(async (connectionString) =>
Expand Down
Loading