-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear button on ConsoleLogs page #7419
Conversation
@Daluur can you add a component bUnit test for this case? |
{ | ||
newConsoleLogsSubscription = new ConsoleLogsSubscription { Name = selectedResourceName }; | ||
Logger.LogDebug("Creating new subscription {SubscriptionId}.", newConsoleLogsSubscription.SubscriptionId); | ||
if (selectedResourceName is not null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: formatting has changed - please change it back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Aspire.Dashboard/Components/Pages/ConsoleLogs.razor.cs:553
- [nitpick] The parameter name 'key' is ambiguous. It should be renamed to 'applicationKey' to improve clarity.
private async Task ClearConsoleLogs(ApplicationKey? key)
I'd like to get this in for 9.1, and we have limited time. @Daluur I'll help make changes on your branch to this PR. |
Yes please |
Unfortunately I don't have any time to look into the required changes until middle of next week. I'll do it then, if @JamesNK have not already done it 😊 |
@Daluur we will do this before Wednesday |
Made some changes. The most notable is to persist filter dates so they're remembered when navigating to and from the console logs page.
|
Description
Adds a button to the console logs pages to clear logs, similar to what has been done in: #6898. I followed the idea of simply filtering logs based on when the remove button was pressed.
Fixes #5458
Checklist
<remarks />
and<code />
elements on your triple slash comments?breaking-change
template):doc-idea
template):