Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis playground app #5726

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Redis playground app #5726

merged 2 commits into from
Sep 16, 2024

Conversation

Alirexaa
Copy link
Contributor

@Alirexaa Alirexaa commented Sep 15, 2024

Add Redis playground app
Related #5723

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Sep 15, 2024
@davidfowl davidfowl added area-integrations Issues pertaining to Aspire Integrations packages and removed area-components labels Sep 16, 2024
@davidfowl
Copy link
Member

Something isn't wire up properly.

 Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk(testEndpoints: Redis.AppHost (1 resources)) [FAIL]
  [xUnit.net 00:00:01.13]       System.IO.FileNotFoundException : Could not load file or assembly '/datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/bin/Debug/net8.0/Redis.AppHost.dll'. The system cannot find the file specified.
  [xUnit.net 00:00:01.13]       System.IO.FileNotFoundException : Could not load file or assembly '/datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/bin/Debug/net8.0/Redis.AppHost.dll'. The system cannot find the file specified.
  [xUnit.net 00:00:01.13]       
  [xUnit.net 00:00:01.13]       
  [xUnit.net 00:00:01.13]       Stack Trace:
  [xUnit.net 00:00:01.13]       Stack Trace:
  [xUnit.net 00:00:01.13]            at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
  [xUnit.net 00:00:01.13]            at System.Runtime.Loader.AssemblyLoadContext.LoadFromAssemblyPath(String assemblyPath)
  [xUnit.net 00:00:01.13]            at System.Reflection.Assembly.LoadFrom(String assemblyFile)
  [xUnit.net 00:00:01.13]            at System.Reflection.Assembly.LoadFrom(String assemblyFile)
  [xUnit.net 00:00:01.13]         /datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/Infrastructure/DistributedApplicationTestFactory.cs(23,0): at SamplesIntegrationTests.DistributedApplicationTestFactory.CreateAsync(String appHostAssemblyPath, ITestOutputHelper testOutput)
  [xUnit.net 00:00:01.13]         /datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/Infrastructure/DistributedApplicationTestFactory.cs(23,0): at SamplesIntegrationTests.DistributedApplicationTestFactory.CreateAsync(String appHostAssemblyPath, ITestOutputHelper testOutput)
  [xUnit.net 00:00:01.13]         /datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/AppHostTests.cs(53,0): at Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk(TestEndpoints testEndpoints)
  [xUnit.net 00:00:01.13]         /datadisks/disk1/work/B9D40977/w/BACC09B3/e/tests/Aspire.Playground.Tests/AppHostTests.cs(53,0): at Aspire.Playground.Tests.AppHostTests.TestEndpointsReturnOk(TestEndpoints testEndpoints)
  [xUnit.net 00:00:01.13]         --- End of stack trace

@davidfowl davidfowl merged commit 3ed2c1b into dotnet:main Sep 16, 2024
11 checks passed
@Alirexaa Alirexaa deleted the redis-playground branch September 16, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-integrations Issues pertaining to Aspire Integrations packages community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants