Skip to content

Commit

Permalink
Don't use a shared session folder.
Browse files Browse the repository at this point in the history
- Each session should have a different folder for maximum isolation. We'll need a different strategy here.
  • Loading branch information
davidfowl committed Feb 4, 2025
1 parent c1c9666 commit 1832735
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 0 additions & 1 deletion eng/pipelines/templates/BuildAndTest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ steps:
DOTNET_ASPIRE_DEPENDENCY_CHECK_TIMEOUT: 180
DCP_DIAGNOSTICS_LOG_LEVEL: debug
DCP_DIAGNOSTICS_LOG_FOLDER: $(Build.ArtifactStagingDirectory)/artifacts/log/dcp
DCP_SESSION_FOLDER: $(Build.ArtifactStagingDirectory)/artifacts/log/dcp/session
DCP_PRESERVE_EXECUTABLE_LOGS: 1
displayName: Run non-helix tests

Expand Down
3 changes: 1 addition & 2 deletions tests/helix/send-to-helix-inner.proj
Original file line number Diff line number Diff line change
Expand Up @@ -151,10 +151,9 @@

<HelixPreCommand Condition="'$(OS)' == 'Windows_NT'" Include="dotnet dev-certs https --trust" />

<!-- Set the DCP_DIAGNOSTICS_LOG_LEVEL env -->
<!-- Set the DCP env -->
<HelixPreCommand Include="$(_EnvVarSetKeyword) DCP_DIAGNOSTICS_LOG_LEVEL=debug" />
<HelixPreCommand Include="$(_EnvVarSetKeyword) DCP_DIAGNOSTICS_LOG_FOLDER=$(_HelixLogsPath)" />
<HelixPreCommand Include="$(_EnvVarSetKeyword) DCP_SESSION_FOLDER=$(_HelixLogsPath)" />
<HelixPreCommand Include="$(_EnvVarSetKeyword) DCP_PRESERVE_EXECUTABLE_LOGS=1" />

<HelixPostCommand Include="$(_WaitForDcpCommand)" />
Expand Down

0 comments on commit 1832735

Please sign in to comment.