Fix build of PNSE assemblies with --no-dependencies
#6801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericstj
commented
Jan 14, 2021
| @@ -41,7 +42,7 @@ | |||
| Projects="@(ProjectReference)" | |||
| Targets="GetCompileItems" | |||
| Properties="%(ProjectReference.SetTargetFramework)" | |||
| Condition="'%(ProjectReference.Identity)' == '$(ContractProject)' and '$(BuildingInsideVisualStudio)' == 'true'"> | |||
| Condition="'%(ProjectReference.Targets)' == 'GetCompileItems' and ('$(BuildingInsideVisualStudio)' == 'true' or '$(BuildProjectReferences)' != 'true')"> | |||
There was a problem hiding this comment.
Conditioning off the Targets value avoids duplicates when the project is referenced for ResolveMatchingContract.
ViktorHofer
approved these changes
Jan 14, 2021
|
Thanks, happy that we are thinking about edge cases as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on dotnet/runtime#46999 I noticed that
dotnet build --no-dependenciesdidn't work for PNSE assemblies. Basically MSBuild treats this similarly to when building a sln. See conditions here: https://github.com/dotnet/msbuild/blob/9954584470022a3d81401189e78443196ee266f9/src/Tasks/Microsoft.Common.CurrentVersion.targets#L1875This permits --no-dependencies to work.