Skip to content

[tests] parameterize IncrementalBuildTest for all runtimes #10119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[tests] parameterize IncrementalBuildTest for all runtimes #10119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 49 additions & 7 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/IncrementalBuildTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,19 @@

namespace Xamarin.Android.Build.Tests
{
[TestFixture (AndroidRuntime.MonoVM)]
[TestFixture (AndroidRuntime.NativeAOT)]
[TestFixture (AndroidRuntime.CoreCLR)]
[Parallelizable (ParallelScope.Children)]
public class IncrementalBuildTest : BaseTest
public class IncrementalBuildTest (AndroidRuntime runtime) : BaseTest
{
readonly AndroidRuntime _runtime = runtime;

[Test]
public void BasicApplicationRepetitiveBuild ()
{
var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder ()) {
b.ThrowOnBuildFailure = false;
Assert.IsTrue (b.Build (proj), "first build failed");
Expand All @@ -45,6 +51,7 @@ public void BasicApplicationRepetitiveBuild ()
public void BasicApplicationRepetitiveReleaseBuild ()
{
var proj = new XamarinAndroidApplicationProject () { IsRelease = true };
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder ()) {
var foo = new BuildItem.Source ("Foo.cs") {
TextContent = () => @"using System;
Expand Down Expand Up @@ -79,6 +86,7 @@ public void CheckNothingIsDeletedByIncrementalClean ([Values (true, false)] bool
ProjectName = "App1",
IsRelease = true,
};
proj.SetRuntime (_runtime);
if (enableMultiDex)
proj.SetProperty ("AndroidEnableMultiDex", "True");
using (var b = CreateApkBuilder (path)) {
Expand Down Expand Up @@ -135,14 +143,15 @@ public void CheckResourceDirectoryDoesNotGetHosed ()
ProjectName = "App1",
IsRelease = true,
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (path, false, false)) {
Assert.IsTrue(b.Build (proj), "First should have succeeded");
Assert.IsTrue (b.Build (proj), "First should have succeeded");
Assert.IsFalse (
b.Output.IsTargetSkipped ("_GenerateAndroidResourceDir"),
"the _GenerateAndroidResourceDir target should not be skipped");
File.SetLastWriteTimeUtc (Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath, "build.props"),
DateTime.UtcNow);
Assert.IsTrue(b.Build (proj), "Second should have succeeded");
Assert.IsTrue (b.Build (proj), "Second should have succeeded");
Assert.IsFalse (
b.Output.IsTargetSkipped ("_GenerateAndroidResourceDir"),
"the _GenerateAndroidResourceDir target should not be skipped");
Expand All @@ -157,6 +166,7 @@ public void IncrementalCleanDuringClean ()
ProjectName = "App1",
IsRelease = true,
};
proj.SetRuntime (_runtime);
proj.SetProperty ("AndroidUseManagedDesignTimeResourceGenerator", "True");
proj.SetProperty ("AndroidUseDesignerAssembly", "False");
using (var b = CreateApkBuilder (path)) {
Expand Down Expand Up @@ -202,6 +212,7 @@ public void LibraryIncrementalBuild ()
}
},
};
lib.SetRuntime (_runtime);
using (var b = CreateDllBuilder ()) {
Assert.IsTrue (b.Build (lib), "first build should have succeeded.");
var aarPath = Path.Combine (Root, b.ProjectDirectory, lib.OutputPath, $"{lib.ProjectName}.aar");
Expand All @@ -225,12 +236,14 @@ public void AllProjectsHaveSameOutputDirectory()
PackageName = "com.companyname.App1",
OutputPath = Path.Combine("..","bin","Debug"),
};
app1.SetRuntime (_runtime);
sb.Projects.Add (app1);
var app2 = new XamarinAndroidApplicationProject () {
ProjectName = "App2",
PackageName = "com.companyname.App2",
OutputPath = Path.Combine("..","bin","Debug"),
};
app2.SetRuntime (_runtime);
sb.Projects.Add (app2);
Assert.IsTrue (sb.Build (), "Build of solution should have succeeded");
Assert.IsTrue (sb.ReBuild (), "ReBuild of solution should have succeeded");
Expand All @@ -252,6 +265,7 @@ public void BuildSolutionWithMultipleProjectsInParallel ()
AotAssemblies = true,
IsRelease = true,
};
app1.SetRuntime (_runtime);
app1.SetProperty ("AndroidEnableMarshalMethods", "True");
sb.Projects.Add (app1);
}
Expand Down Expand Up @@ -280,6 +294,7 @@ public TestMe createTestMe () {
}
},
};
app.SetRuntime (_runtime);

using (var b = CreateApkBuilder (Path.Combine ("temp", "JavacTaskDoesNotRunOnSecondBuild"), false, false)) {
Assert.IsTrue (b.Build (app), "First build should have succeeded");
Expand Down Expand Up @@ -332,6 +347,7 @@ public Class1 ()
},
},
};
lib.SetRuntime (_runtime);
var so = lib.OtherBuildItems.First (x => x.Include () == "libs/armeabi-v7a/libfoo.so");

var lib2 = new XamarinAndroidLibraryProject () {
Expand Down Expand Up @@ -363,6 +379,7 @@ public Class2 ()
},
},
};
lib2.SetRuntime (_runtime);
var path = Path.Combine (Root, "temp", TestName);
using (var libbuilder = CreateDllBuilder (Path.Combine(path, "Lib"))) {

Expand Down Expand Up @@ -427,6 +444,7 @@ public void AppProjectTargetsDoNotBreak ()
}
}
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "first build should succeed");
var firstBuildTime = b.LastBuildTime;
Expand Down Expand Up @@ -498,6 +516,7 @@ public void LibraryProjectTargetsDoNotBreak ()
},
},
};
proj.SetRuntime (_runtime);
using (var b = CreateDllBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "first build should succeed");
foreach (var target in targets) {
Expand Down Expand Up @@ -528,6 +547,7 @@ public void ManifestMergerIncremental ()
var proj = new XamarinAndroidApplicationProject {
ManifestMerger = "manifestmerger.jar"
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder ()) {
Assert.IsTrue (b.Build (proj), "first build should succeed");
b.Output.AssertTargetIsNotSkipped ("_ManifestMerger");
Expand Down Expand Up @@ -557,6 +577,7 @@ public void ProduceReferenceAssembly ()
},
}
};
app.SetRuntime (_runtime);

int count = 0;
var lib = new DotNetStandard {
Expand Down Expand Up @@ -607,6 +628,7 @@ public void TransitiveDependencyProduceReferenceAssembly ()
},
}
};
app.SetRuntime (_runtime);
var lib1 = new DotNetStandard {
ProjectName = "Library1",
Sdk = "Microsoft.NET.Sdk",
Expand Down Expand Up @@ -664,6 +686,7 @@ public void TransitiveDependencyProduceReferenceAssembly ()
public void LinkAssembliesNoShrink ()
{
var proj = new XamarinFormsAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "build should have succeeded.");

Expand All @@ -687,6 +710,7 @@ public void CSProjUserFileChanges ()
AssertCommercialBuild ();

var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
var selectedDevice = "foo";
var csproj_user_file = $"{proj.ProjectName}.csproj.user";
proj.Sources.Add (new BuildItem.NoActionResource (csproj_user_file) {
Expand Down Expand Up @@ -736,6 +760,7 @@ public CustomTextView(Context context, IAttributeSet attributes) : base(context,
}
}
};
app.SetRuntime (_runtime);
// Use a custom view
app.LayoutMain = app.LayoutMain.Replace ("</LinearLayout>", "<MyApp.CustomTextView android:id=\"@+id/myText\" android:text=\"à请\" /></LinearLayout>");

Expand Down Expand Up @@ -812,6 +837,7 @@ public CustomTextView(Context context, IAttributeSet attributes) : base(context,
public void ResolveLibraryProjectImports ()
{
var proj = new XamarinFormsAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "first build should have succeeded.");
var intermediate = Path.Combine (Root, b.ProjectDirectory, proj.IntermediateOutputPath);
Expand Down Expand Up @@ -912,15 +938,16 @@ public void AddNewAndroidResourceOnSecondBuild ()
};

var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
var projectFile = Path.Combine (Root, b.ProjectDirectory, proj.ProjectFilePath);
b.ThrowOnBuildFailure = false;
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
b.Output.AssertTargetIsNotSkipped ("_GenerateAndroidResourceDir");
proj.OtherBuildItems.Add (xml);
b.Save (proj, doNotCleanupOnUpdate: true);
var modified = File.GetLastWriteTimeUtc (Path.Combine (Root, b.ProjectDirectory, "Resources","layout","Main.axml"));
File.SetLastWriteTimeUtc (Path.Combine (Root, b.ProjectDirectory, "Resources","values", "emptyvalues.xml"), modified);
var modified = File.GetLastWriteTimeUtc (Path.Combine (Root, b.ProjectDirectory, "Resources", "layout", "Main.axml"));
File.SetLastWriteTimeUtc (Path.Combine (Root, b.ProjectDirectory, "Resources", "values", "emptyvalues.xml"), modified);
Assert.IsTrue (b.Build (proj), "Build should have succeeded.");
b.Output.AssertTargetIsNotSkipped ("_GenerateAndroidResourceDir");
}
Expand All @@ -935,6 +962,7 @@ public void InvalidAndroidResource ()
};

var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
var projectFile = Path.Combine (Root, b.ProjectDirectory, proj.ProjectFilePath);
b.ThrowOnBuildFailure = false;
Expand Down Expand Up @@ -974,6 +1002,7 @@ public void CasingOnJavaLangObject ()
},
}
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "first build should have succeeded.");
className = "fOO";
Expand All @@ -992,6 +1021,7 @@ public void GenerateJavaStubsAndAssembly ([Values (true, false)] bool isRelease)
var proj = new XamarinAndroidApplicationProject {
IsRelease = isRelease,
};
proj.SetRuntime (_runtime);
proj.SetAndroidSupportedAbis ("armeabi-v7a");
proj.OtherBuildItems.Add (new AndroidItem.AndroidEnvironment ("Foo.txt") {
TextContent = () => "Foo=Bar",
Expand Down Expand Up @@ -1101,6 +1131,7 @@ public void BuildIncrementalAot (string supportedAbis, string androidAotMode, bo
}
}
};
proj.SetRuntime (_runtime);
proj.AddReference (libB);
if (aotAssemblies) {
targets.Add ("_AndroidAot");
Expand Down Expand Up @@ -1170,6 +1201,7 @@ public void DeterministicBuilds ([Values (true, false)] bool deterministic)
//NOTE: so _BuildApkEmbed runs in commercial tests
EmbedAssembliesIntoApk = true,
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder ()) {
Assert.IsTrue (b.Build (proj), "first build should have succeeded.");
var output = Path.Combine (Root, b.ProjectDirectory, proj.OutputPath, $"{proj.ProjectName}.dll");
Expand Down Expand Up @@ -1199,6 +1231,7 @@ public void DeterministicBuilds ([Values (true, false)] bool deterministic)
public void DesignTimeBuild ()
{
var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", $"{nameof (IncrementalBuildTest)}{TestName}"))) {
b.BuildLogFile = "dtb1.log";
Assert.IsTrue (b.DesignTimeBuild (proj), "first dtb should have succeeded.");
Expand Down Expand Up @@ -1229,6 +1262,7 @@ public void DesignTimeBuildSignAndroidPackage ()
var proj = new XamarinAndroidApplicationProject () {
EnableDefaultItems = true,
};
proj.SetRuntime (_runtime);
proj.SetProperty ("AndroidUseDesignerAssembly", "true");
var builder = CreateApkBuilder ();
var parameters = new [] { "BuildingInsideVisualStudio=true"};
Expand Down Expand Up @@ -1258,6 +1292,7 @@ public void DesignTimeBuildSignAndroidPackage ()
public void ChangePackageNamingPolicy ()
{
var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
proj.Sources.Add (new BuildItem.Source ("Bar.cs") {
TextContent = () => "namespace Foo { class Bar : Java.Lang.Object { } }"
});
Expand Down Expand Up @@ -1298,6 +1333,7 @@ public void MissingProjectReference ()
},
}
};
app.SetRuntime (_runtime);
var reference = $"..\\{lib.ProjectName}\\{lib.ProjectName}.csproj";
app.References.Add (new BuildItem.ProjectReference (reference, lib.ProjectName, lib.ProjectGuid));

Expand Down Expand Up @@ -1335,6 +1371,7 @@ public void AaptError ()
}
}
};
proj.SetRuntime (_runtime);
using (var builder = CreateApkBuilder ()) {
builder.ThrowOnBuildFailure = false;
Assert.IsFalse (builder.Build (proj), "Build should *not* have succeeded on the first build.");
Expand All @@ -1346,6 +1383,7 @@ public void AaptError ()
public void AndroidResourceChange ()
{
var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
using (var builder = CreateApkBuilder ()) {
Assert.IsTrue (builder.Build (proj), "first build should succeed");

Expand All @@ -1367,6 +1405,7 @@ public void AndroidAssetChange ()
{
var text = "Foo";
var proj = new XamarinAndroidApplicationProject ();
proj.SetRuntime (_runtime);
proj.OtherBuildItems.Add (new AndroidItem.AndroidAsset ("Assets\\Foo.txt") {
TextContent = () => text
});
Expand Down Expand Up @@ -1409,6 +1448,7 @@ public void AndroidAssetMissing ()
},
}
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder ()) {
Assert.IsTrue (b.Build (proj), "first build should succeed");

Expand All @@ -1434,10 +1474,11 @@ public void AndroidAssetMissing ()
public void ChangeSupportedAbis ()
{
var proj = new XamarinFormsAndroidApplicationProject ();
proj.SetAndroidSupportedAbis ("armeabi-v7a");
proj.SetRuntime (_runtime);
proj.SetAndroidSupportedAbis ("arm64-v8a");
using (var b = CreateApkBuilder ()) {
b.Build (proj);
b.Build (proj, parameters: new [] { $"{KnownProperties.RuntimeIdentifier}=android-x86" }, doNotCleanupOnUpdate: true);
b.Build (proj, parameters: new [] { $"{KnownProperties.RuntimeIdentifier}=android-x64" }, doNotCleanupOnUpdate: true);
}
}

Expand All @@ -1456,6 +1497,7 @@ public void BuildPropsBreaksConvertResourcesCasesOnSecondBuild ()
}
}
};
proj.SetRuntime (_runtime);
using (var b = CreateApkBuilder (Path.Combine ("temp", TestName))) {
Assert.IsTrue (b.Build (proj), "first build should have succeeded.");
var assemblyPath = Path.Combine (Root, b.ProjectDirectory, proj.OutputPath, "UnnamedProject.dll");
Expand Down
Loading