Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parallel builds #2563

Closed
wants to merge 2 commits into from
Closed

Fix parallel builds #2563

wants to merge 2 commits into from

Conversation

timcassell
Copy link
Collaborator

Fixes #2425

Builds using dotnet sdk 8 or newer use ArtifactsPath to enable safe parallel builds. Builds using older dotnet sdks and wasm and monoaotllvm build sequentially.

It would be nice to enable parallel builds also for wasm and monoaotllvm, but I can't test them on my machine, so I'm not sure why it doesn't work with those toolchains. cc @LoopedBard3 @caaavik-msft

MonoPublisher inherits from DotNetCliBuilderBase.
Don't repeat sequential builds.
@timcassell timcassell force-pushed the fix-parallel-builds branch from 3285f50 to 2b4c775 Compare August 30, 2024 17:40
@timcassell timcassell marked this pull request as draft December 14, 2024 14:03
@timcassell
Copy link
Collaborator Author

Closing in favor of #2676.

@timcassell timcassell closed this Dec 14, 2024
@timcassell timcassell deleted the fix-parallel-builds branch December 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WithCustomBuildConfiguration breaks build
1 participant