Fix Mono AOT LLVM #2539
Merged
Fix Mono AOT LLVM #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm fixing a 2nd bug in this PR, if you specified a moniker |
LoopedBard3
approved these changes
Mar 8, 2024
|
Do we need to account for |
|
I have created another issue for that: #2540 |
|
It would also be nice to get integration tests for this (#2536). |
timcassell
approved these changes
Mar 8, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to what broke with the WASM runs, it seems that Mono AOT LLVM also will always append the
publishdirectory onto the end of theOutDirandOutputPaththat we pass in, so we need to remove it from the end of those paths and then append it the executable path and working directory.We are doing some more testing on this first before it can be ready to merge however, but this seems like the likely fix.Testing is done, this PR is ready for a merge.