Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GenerateAndBuildOnly Option #2225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lihaMSFT
Copy link

@lihaMSFT lihaMSFT commented Dec 9, 2022

This PR adds an option to run toolchain generator and builder without actually executing the built binary.

This way we can attach other tools such as perfview and Visual Studio Performance Profiler to profile the benchmarks.

@dnfadmin
Copy link

dnfadmin commented Dec 9, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lihaMSFT

Thank you for your contribution! The PR LGTM, but I would like to better understand what you are trying to achieve.

This way we can attach other tools such as perfview and Visual Studio Performance Profiler to profile the benchmarks.

BDN provides a possibility to implement your own plugin, by implementing the IDiagnoser iterface. It allowed us to implement few profiler plugins:

What are these built-in profilers missing? Perhaps we could just implement a new one that would be integrated with Visual Studio Profiler?

Thanks,
Adam

src/BenchmarkDotNet/Reports/BenchmarkReport.cs Outdated Show resolved Hide resolved
@lihaMSFT lihaMSFT force-pushed the dev/liha/GenerateAndBuildOnly branch from deb927d to b3a06e1 Compare December 9, 2022 20:43
@lihaMSFT
Copy link
Author

lihaMSFT commented Dec 9, 2022

Hello Adam,

VS Performance Profiler supports multiple types of profiling: CPU, instrumentation, object allocation and has a large API surface. We can discuss a potential integration in the future.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants