Skip to content

Improve OnNotFound example #35475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Improve OnNotFound example #35475

merged 2 commits into from
May 16, 2025

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented May 15, 2025

Fixes #35468
Addresses #34437

Ilona ... IMO, much better than what I had here. Your example concept is GrEaT! 🎉 A few notes ...

  • This adopts my strategy of using fully working, cut-'n-paste examples for demos, which devs enjoy. Eventually, this example code will make its way into the Blazor sample apps.
  • I changed some bits here and there, such as making the Context into a Heading property, and I'm 👂 for improvements.
  • The Routing article is now too long and too full of advanced concepts, so I'll be creating a Routing node of articles or a single article in the reference docs and downsize this "fundamentals" article to focus on basic concepts. For now, we'll just place this new content here, but I think this will become an advanced scenario for a different article later. That work is tracked by Split out advanced routing and nagivation coverage (dotnet/AspNetCore.Docs #35474).

Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/fundamentals/routing.md aspnetcore/blazor/fundamentals/routing

@guardrex guardrex self-assigned this May 15, 2025
@guardrex guardrex requested a review from ilonatommy May 15, 2025 11:47
Copy link
Member

@ilonatommy ilonatommy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting it on paper so neatly. Looks great

@guardrex guardrex merged commit 2d6d07d into main May 16, 2025
3 checks passed
@guardrex guardrex deleted the guardrex/improve-onnotfound-example branch May 16, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pre4] Improve OnNotFound example
2 participants