-
Notifications
You must be signed in to change notification settings - Fork 25.2k
[Pre4] Blazor WASM performance profiling #35243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not on nightly builds. The untested examples are taken from your issue/PR remarks. I can go nightly if needed for testing, but I think you'll be able to suggest corrections based on what's on the PR.
I did the first pass. My main messages are
- please try it yourself.
- the dev tools profiling and EP/DS profiling are quite different set of tools and not compatible with each other. I would prefer them on separate page.
- log profiler should not be mentioned.
UPDATE (4/25): I've been bogged down in security work all week. I should be able to get back to this early next week. |
@pavelsavara ... Made the update pass. A few notes ......
|
Maybe "Diagnostics with Event Pipe on WASM" or something like that.
At least watch Daniel's demo of it please.
The idea I'm trying to convey is that you the user own that symbol (and it's conflicts with other stuff). They could also name it
Let's not promise things, I am not going to do it myself. Especially not with this specific symbol name. |
aspnetcore/blazor/performance/browser-developer-tools-profiling.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/browser-developer-tools-profiling.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/browser-developer-tools-profiling.md
Outdated
Show resolved
Hide resolved
@pavelsavara ... Articles are now ... Browser developer tools:
Event Pipe:
|
This comment was marked as resolved.
This comment was marked as resolved.
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
Updates made! This was one of the very rare cases where my attempt to proactively resolve a preview issue to save time and effort failed. 😢 It shouldn't be a problem going forward under the new plan for preview feature documentation. |
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
Updates made! ... and I make some improvements to the layout and content of those sections. |
@pavelsavara ... Are we ready to jam on this one? 🎷 This was a bit painful 🤕 given my lack of knowledge in this area. It shouldn't happen again now that the preview draft guidance will come from the PU engineers in the future. |
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-browser-developer-tools-diagnostics.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/performance/webassembly-event-pipe-diagnostics.md
Outdated
Show resolved
Hide resolved
@pavelsavara ... Updates made. |
let's merge this |
Fixes #35230
Addresses #34437
Notes
performance.md
file into a set of shorter articles. The only one that you need to review is theprofiling.md
article.ds-router
remarks from the draft content.profiling.md
markdown file directly.Debug
configuration (i.e., applying one or moreCondition
attributes and/or targets+properties) so that profiling won't accidentally be left enabled for a published (released) app?Internal previews
Toggle expand/collapse