New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding testing framework #11

Closed

Sbhat92 wants to merge 1 commit into dotlas:main from Sbhat92:main

Sbhat92 commented May 12, 2023

Added testing framework, addressing unit tests for each function that calls the Dotlas API endpoints can be developed with pytest. Issue #2


          adding testing framework

0ec4fe6

Member

cricksmaidiene commented May 27, 2023

Thank you for submitting a PR, however:

pytest is preferable to unittest since it can be integrated with plugins, and generally has better performance
The mock values for the endpoints are incorrect in the test cases
Generally you want to include multiple test cases
The coverage of these tests are only for simple endpoints and do not seem to cover the more complex endpoints
No mention of adding CI for tests, or whether this PR covers it

Please submit a new PR based on the above, and with more details on what is being achieved and what would require further development.

cricksmaidiene closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet