Add rolling admission field to career opportunity #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikhorluck
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Får vi ikke samme effekt av å si at frist + snarest = løpende?
Nå overkjører snarest alltid fristen, men det må den jo ikke.
snarest = not søknader_vurderes_bare_etter_fristen?
Evt. bytte navn på snarest til "rolling admission" eller noe annet som bedre reflekterer hva det innebærer
henrikhorluck
requested changes
Sep 19, 2024
| ] | ||
|
|
||
| operations = [ | ||
| migrations.RemoveField( |
There was a problem hiding this comment.
Hvorfor er det bedre? Django autogenererte migrationen.
There was a problem hiding this comment.
Fordi hvis ikke sletter du eksisterende data?
Django "scaffolder" bare, du må selv si hvorvidt det du gjør er en rename eller et nytt separat felt—hvordan skal django kunne detektere forskjellen?
There was a problem hiding this comment.
Veldig godt poeng, hadde ikke tenkt på det. Fikser!
henrikhorluck
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotkom/onlineweb-frontend#745
Endret navn fra deadline_asap til rolling_admission.